Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: update /doc/install/source page after GO386 changes #41861

Open
ALTree opened this issue Oct 8, 2020 · 4 comments
Open

x/website: update /doc/install/source page after GO386 changes #41861

ALTree opened this issue Oct 8, 2020 · 4 comments

Comments

@ALTree
Copy link
Member

@ALTree ALTree commented Oct 8, 2020

The Installing Go from source page says (in the section dedicated to Env Variables):

$GO386 (for 386 only, default is auto-detected if built on either 386 or amd64, 387 otherwise)

This controls the code generated by gc to use either the 387 floating-point unit (set to 387) or SSE2 instructions (set to sse2) for floating point computations.

  • GO386=387: use x87 for floating point operations; should support all x86 chips (Pentium MMX or later).
  • GO386=sse2: use SSE2 for floating point operations; has better performance than 387, but only available on Pentium 4/Opteron/Athlon 64 or later.

The section should be updated to reflect the planned 1.16 deprecation of 387, and the softfloat support.

cc @dmitshur

@ALTree ALTree added the Documentation label Oct 8, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 8, 2020
@ALTree ALTree added the NeedsFix label Oct 8, 2020
@ALTree ALTree modified the milestones: Unreleased, Go1.16 Oct 8, 2020
@ALTree ALTree changed the title x/website: update install from source page after GO386 changes doc: update install from source page after GO386 changes Oct 8, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 8, 2020

Thanks for spotting this @ALTree.

@randall77 Would you like to send a CL for this? The file that needs to be updated is in x/website, here. (There's also an old copy of it in the main repo, but that needs to be deleted; I re-opened #40496 (comment) for that.)

Edit: Since the file is in x/website, we should not submit the CL until Go 1.16 comes out. Can add wait-release hashtag to it.

@dmitshur dmitshur changed the title doc: update install from source page after GO386 changes x/website: update /doc/install/source page after GO386 changes Oct 8, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 8, 2020

Change https://golang.org/cl/260757 mentions this issue: doc: update install docs for 387->softfloat transition

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 8, 2020

Change https://golang.org/cl/260700 mentions this issue: content/static/doc: update install docs for 387->softfloat transition

@gopherbot gopherbot closed this in 2be7788 Oct 9, 2020
gopherbot pushed a commit to golang/website that referenced this issue Oct 12, 2020
Fixes golang/go#41861

Change-Id: Ib24851e4423d63cc7baa7bee176798f6eb35364d
Reviewed-on: https://go-review.googlesource.com/c/website/+/260700
Trust: Keith Randall <khr@golang.org>
Trust: Alberto Donizetti <alb.donizetti@gmail.com>
Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 14, 2020

Reopening because the x/website CL was reverted in CL 261557. x/website needs to be modified when Go 1.16 is released. I'll move this to Go 1.17 milestone with early-in-cycle.

@dmitshur dmitshur reopened this Oct 14, 2020
@dmitshur dmitshur modified the milestones: Go1.16, Go1.17 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.