Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: set up extended regtest CI #41865

Open
findleyr opened this issue Oct 8, 2020 · 2 comments
Open

x/tools/gopls: set up extended regtest CI #41865

findleyr opened this issue Oct 8, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented Oct 8, 2020

In https://golang.org/cl/259137, I configured the regtests to only run in 'singleton' mode by default (communicating with the server via stdin/stdout).

This change was made because also running in 'forwarded' mode provides only fractionally more test coverage, and causes the tests to run more than 2x longer. Particularly on Darwin and Android builders, the regtests have gotten quite slow.

By running in parallel on Linux, the regtests can be made to run in <10s. We should set up extended CI (using Kokoro) to run the regtests in forwarded mode, and possibly even more modes: run with a separate daemon process, run with all experiments enabled, run in a nested module, etc.

This would achieve coverage of various execution modes without slowing down the builders.

CC @stamblerre

@gopherbot gopherbot added this to the Unreleased milestone Oct 8, 2020
@findleyr findleyr self-assigned this Oct 8, 2020
@bcmills
Copy link
Member

@bcmills bcmills commented Oct 8, 2020

Would it make sense to condition the additional modes on !testing.Short() rather than a separate Kokoro workflow?

That way the Go project's longtest builders could provide coverage for them.

@findleyr
Copy link
Contributor Author

@findleyr findleyr commented Oct 8, 2020

Would it make sense to condition the additional modes on !testing.Short() rather than a separate Kokoro workflow?

That's a good suggestion, thanks. I think that would probably be sufficient for now.

@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Oct 9, 2020
@stamblerre stamblerre added this to Testing in gopls/v1.0.0 Oct 12, 2020
@stamblerre stamblerre moved this from Testing to Assigned in gopls/v1.0.0 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.