Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access: Approver Access ("approvers") #41898

Closed
mengzhuo opened this issue Oct 10, 2020 · 5 comments
Closed

access: Approver Access ("approvers") #41898

mengzhuo opened this issue Oct 10, 2020 · 5 comments
Assignees
Labels
Milestone

Comments

@mengzhuo
Copy link
Contributor

@mengzhuo mengzhuo commented Oct 10, 2020

Gerrit email: mzh@golangcn.org

Approver Access ("approvers")

https://go-review.googlesource.com/#/admin/groups/1005,members

Hi, @dmitshur

I need approver access some well test CLs takes too long to submit (i.e. https://go-review.googlesource.com/c/go/+/180757)

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Oct 10, 2020

@mengzhuo sorry for the delay. Please ping me if a CL does not get a response for ~a week. Thanks.

@mengzhuo
Copy link
Contributor Author

@mengzhuo mengzhuo commented Oct 12, 2020

@mengzhuo sorry for the delay. Please ping me if a CL does not get a response for ~a week. Thanks.

Hi, Cherry
I just wish that I can take the load off for you :)

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 13, 2020

Thank you for making the request @mengzhuo, we will consider it.

@dmitshur dmitshur removed the NeedsDecision label Oct 13, 2020
@benshi001
Copy link
Member

@benshi001 benshi001 commented Oct 13, 2020

Mengzhou has been around for a long time, and made many commits.

I think he need not two +2 votes for his future CLs, so giving him the approver access can simplify his future work.

Actually I am an approver but less use my access.

@cagedmantis cagedmantis added this to the Backlog milestone Oct 19, 2020
@toothrot
Copy link
Contributor

@toothrot toothrot commented Oct 21, 2020

You're good to go. Thanks for your contributions!

@toothrot toothrot closed this Oct 21, 2020
@toothrot toothrot self-assigned this Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.