Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev.go2go: please rebase against master or at least 1.15. #41909

Open
OneOfOne opened this issue Oct 10, 2020 · 5 comments
Open

dev.go2go: please rebase against master or at least 1.15. #41909

OneOfOne opened this issue Oct 10, 2020 · 5 comments
Assignees
Labels
Milestone

Comments

@OneOfOne
Copy link
Contributor

@OneOfOne OneOfOne commented Oct 10, 2020

I used to manually rebase it but the changes are a bit too much atm.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 11, 2020

@griesemer
Copy link
Contributor

@griesemer griesemer commented Oct 11, 2020

As this is a prototype and we wanted to keep a clean history of changes, in the past I have simply rebased the entire sequence of commits on top of master, and then rewritten the history in the repo.

Is this still acceptable?

@OneOfOne
Copy link
Contributor Author

@OneOfOne OneOfOne commented Oct 12, 2020

@griesemer Yep that would be perfect.

@griesemer
Copy link
Contributor

@griesemer griesemer commented Oct 13, 2020

Just FYI: This may happen as needed; but it's not urgent as this branch is just a prototype.

@OneOfOne
Copy link
Contributor Author

@OneOfOne OneOfOne commented Oct 13, 2020

Yeah completely understandable, I have no problem rebasing it myself most of the time but around the 1.15 release something major changed and I just couldn't get it to compile at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants