Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: request.Clone doesn't deep copy TransferEncoding [1.14 backport] #41913

Closed
gopherbot opened this issue Oct 10, 2020 · 3 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 10, 2020

@odeke-em requested issue #41907 to be considered for backport to the next 1.14 minor release.

Thank you for catching this @dqu123 and welcome to the Go project! Good eyes.

@gopherbot please backport this issue.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 11, 2020

Change https://golang.org/cl/261377 mentions this issue: [release-branch.go1.14] net/http: deep copy Request.TransferEncoding

@toothrot toothrot modified the milestones: Go1.14.10, Go1.14.11 Oct 14, 2020
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Oct 22, 2020

Approved as this is an issue without a workaround.

gopherbot pushed a commit that referenced this issue Oct 23, 2020
The existing implementation in Request.Clone() assigns the wrong
pointer to r2.TransferEncoding.

Updates #41907.
Fixes #41913.

Change-Id: I7f220a41b1b46a55d1a1005e47c6dd69478cb025
Reviewed-on: https://go-review.googlesource.com/c/go/+/261377
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Carlos Amedee <carlos@golang.org>
Trust: Emmanuel Odeke <emm.odeke@gmail.com>
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 23, 2020

Closed by merging 3109de2 to release-branch.go1.14.

@gopherbot gopherbot closed this Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants