Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: ASCII graphics on pkg.go.dev looks worse than on godoc.org #41919

Closed
amlinux opened this issue Oct 11, 2020 · 3 comments
Closed

x/pkgsite: ASCII graphics on pkg.go.dev looks worse than on godoc.org #41919

amlinux opened this issue Oct 11, 2020 · 3 comments
Assignees
@jamalc
Labels
NeedsFix pkgsite
Milestone
pkgsite/frontend

Comments

@amlinux
Copy link

@amlinux amlinux commented Oct 11, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/google.golang.org/protobuf/reflect/protoreflect

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36

Screenshot

image

What did you expect to see?

Diagrams formatted with a fixed-width font, like on godoc.org.

What did you see instead?

Boxes don't look like boxes.
@gopherbot gopherbot added the pkgsite label Oct 11, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 11, 2020
@jba jba added the NeedsInvestigation label Oct 12, 2020
@jba jba modified the milestones: Unreleased, pkgsite/frontend Oct 12, 2020
@jba
Copy link
Contributor

@jba jba commented Oct 12, 2020

cc @jamalc @AceroM
@jamalc jamalc self-assigned this Oct 12, 2020
@jamalc jamalc added NeedsFix and removed NeedsInvestigation labels Oct 12, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 12, 2020

Change https://golang.org/cl/261501 mentions this issue: content/static: use system fonts
@jamalc jamalc closed this Oct 13, 2020
@jamalc
Copy link
Member

@jamalc jamalc commented Oct 13, 2020

Done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamalc jamalc

Labels
NeedsFix pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@amlinux @gopherbot @jamalc @jba