Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/gopls: report better error messages for invalid flags #41942
gopls version: v0.5.1
ATTENTION: PLEASE PROVIDE THE DETAILS REQUESTED BELOW.
Describe what you observed.
Please attach the stack trace from the crash.
OPTIONAL: If you would like to share more information, you can attach your complete gopls logs.
NOTE: THESE MAY CONTAIN SENSITIVE INFORMATION ABOUT YOUR CODEBASE.
<OPTIONAL: ATTACH LOGS HERE>
@hyangah: I guess the real issue is that the crash is not a panic, so it doesn't get picked up by your logic to extract stack traces. The current error message (
@stamblerre I don't worry too much about the issue tracker contents (we already include the gopls flag values in the issue so the setting error was pretty obvious to me :-)
Ideally I want users to figure out this type of setting mistakes by themselves even before sending an issue report to us. I want to know if there is a better way to display this error message. Currently, the error message is buried in stderr and it's not immediately obvious this is significant enough to crash the server. Can it send 'Error' -level logs? Or prefix the message with 'FATAL', or something that sounds serious?