Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/fsys: symlink test failing on Plan 9 #41954

Closed
fhs opened this issue Oct 13, 2020 · 2 comments
Closed

cmd/go/internal/fsys: symlink test failing on Plan 9 #41954

fhs opened this issue Oct 13, 2020 · 2 comments

Comments

@fhs
Copy link
Contributor

@fhs fhs commented Oct 13, 2020

What version of Go are you using (go version)?

$ go version
go version devel +master Tue Oct 13 11:13:17 EDT 2020 plan9/amd64

What did you do?

cpu% cd cmd/go/internal/fsys
cpu% go test 

What did you expect to see?

no test failure

What did you see instead?

--- FAIL: TestWalk_Symlink (0.01s)
    fsys_test.go:664: symlink dir symlink: not supported by plan 9
    --- FAIL: TestWalk_Symlink/symlink_to_dir (0.00s)
        fsys_test.go:686: walkfn: got non nil err argument: stat /tmp/TestWalk_Symlink536627453/001/root/symlink: '/tmp/TestWalk_Symlink536627453/001/root/symlink' does not exist, want nil err argument
    --- FAIL: TestWalk_Symlink/overlay_to_symlink_to_dir (0.00s)
        fsys_test.go:686: walkfn: got non nil err argument: stat /tmp/TestWalk_Symlink536627453/001/root/symlink: '/tmp/TestWalk_Symlink536627453/001/root/symlink' does not exist, want nil err argument
FAIL
exit status: 'fsys.test 86818: 1'
FAIL	cmd/go/internal/fsys	0.344s

@gopherbot add labels OS-Plan9, NeedsFix

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 13, 2020

Change https://golang.org/cl/261897 mentions this issue: cmd/go/internal/fsys: skip symlink test on Plan 9

@jayconrod
Copy link
Contributor

@jayconrod jayconrod commented Oct 13, 2020

Duplicate of #41950

@jayconrod jayconrod marked this as a duplicate of #41950 Oct 13, 2020
@jayconrod jayconrod closed this Oct 13, 2020
gopherbot pushed a commit that referenced this issue Oct 13, 2020
Fixes #41950
Fixes #41954

Change-Id: I95d97f076fa928f3638309b78748d7ccc7277b14
Reviewed-on: https://go-review.googlesource.com/c/go/+/261897
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.