Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: don't register semantic tokens capability unless enabled #41963

Open
stamblerre opened this issue Oct 14, 2020 · 2 comments
Open

x/tools/gopls: don't register semantic tokens capability unless enabled #41963

stamblerre opened this issue Oct 14, 2020 · 2 comments
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Oct 14, 2020

We can register/unregister it dynamically, since it is gated by a flag. We just don't want the client to send semantic tokens requests if the user has disabled semantic tokens.

/cc @pjweinb

@stamblerre stamblerre added this to the gopls/v0.5.2 milestone Oct 14, 2020
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Oct 19, 2020

I think that before we fix this, we need to resolve #41966 by removing the per-view configuration. Semantic tokens are a per-session option, which is why the dynamic configuration is currently tricky to implement.

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 20, 2020

Change https://golang.org/cl/263525 mentions this issue: internal/lsp: dynamically register semantic tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.