Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: prevent submission of CL with an outstanding wait-* hashtag #41979

Open
dmitshur opened this issue Oct 14, 2020 · 0 comments
Open

x/build: prevent submission of CL with an outstanding wait-* hashtag #41979

dmitshur opened this issue Oct 14, 2020 · 0 comments

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 14, 2020

There is a convention of using a wait-* hashtag to indicate a CL is waiting on some specific item before progress can be made. This is described in issue #10658, which may need to be resolved more before progress can be made here.

I suspect it may be helpful to to have an automatic mechanism that prevents a CL from being submitted if it has an active wait-* hashtag. If waiting is no longer necessary, the wait-* hashtag should be removed. This can help avoid accidental early submission. See CL 260700 for a recent example of a CL that was accidentally submitted too early despite having a wait-release hashtag.

Perhaps it can be implemented as gopherbot applying a -2 code review vote (and a comment?), as a Gerrit rule (similar to implementation of Trust votes), or some other way. This is related to #41722, which is about detecting a mismatch in target branch, #10658, which is about detecting large binaries, and to #18548, which is about various server-side checks.

/cc @golang/osp-team

@dmitshur dmitshur added this to the Backlog milestone Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.