Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/ipv6: TestPacketConnReadWriteMulticast{UDP,ICMP} failing with "i/o timeout" on OpenBSD 6.8 #42064

Open
bcmills opened this issue Oct 19, 2020 · 10 comments

Comments

@tklauser
Copy link
Member

@tklauser tklauser commented Dec 2, 2020

This test consistently fails on the openbsd-arm64-jsing and the 386/amd64 builders running OpenBSD 6.8 as well:

openbsd-arm64-jsing: https://build.golang.org/log/be54c3c8bfe2313b55b63b76bc5af92d6c39a524
openbsd-386-68: https://build.golang.org/log/eea81ada598c39d224d3a9a40b4739bbbe739b09
openbsd-amd64-68: https://build.golang.org/log/9039640721536372ca5170299ee6e923aa3775dd

The test also failed on https://golang.org/cl/274772 on the openbsd-mips64-jsing builder.

It doesn't seem to fail on builder running OpenBSD 6.2 or 6.4.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Dec 14, 2020

It doesn't seem to fail on builder running OpenBSD 6.2 or 6.4.

It'd be helpful to find out if the test runs or gets skipped on OpenBSD 6.4. (It's possible it's passing in 6.4 because IPv6 isn't supported there and it gets skipped.)

@bcmills bcmills changed the title x/net/ipv6: TestPacketConnReadWriteMulticastUDP failing with "i/o timeout" on openbsd-arm-jsing builders x/net/ipv6: TestPacketConnReadWriteMulticastUDP failing with "i/o timeout" on OpenBSD builders Dec 21, 2020
@bcmills bcmills removed the arch-arm label Dec 21, 2020
@bcmills
Copy link
Member Author

@bcmills bcmills commented Dec 21, 2020

Marking as release-blocker via #11811, especially since this doesn't seem builder- or arch-specific.

But note that OpenBSD is not a first-class port, so it may be viable to unblock the release by skipping the test on the affected builders — especially given that this appears to be either a regression in the kernel or an incompatible ABI change.

@bcmills bcmills modified the milestones: Unreleased, Go1.16 Dec 21, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 21, 2020

Change https://golang.org/cl/279512 mentions this issue: dashboard: promote OpenBSD 6.8 builders to be default

gopherbot pushed a commit to golang/build that referenced this issue Dec 23, 2020
The known issue with OpenBSD 6.8 builders appears to be resolved
via CL 278732 and CL 279134. Promote them to the primary OpenBSD
post-submit builders and TryBots.

Having test coverage from OpenBSD 6.8 and 6.4 builders gives us
us more confidence that Go works on supported OpenBSD versions
(which are 6.8 and 6.7 at this time, per past policy decision
in https://golang.org/issue/15227#issuecomment-293319876).

Reduce numTryTestHelpers from 5 to 4 based on some data from
golang.org/issue/37439 showing that going from 3 to 5 helpers
doesn't make a significant difference. We can adjust further
if we learn that OpenBSD TryBots become the bottleneck.

Fixes golang/go#35712.
For golang/go#42542.
For golang/go#42064.
Updates golang/go#42426.

Change-Id: Id2fa4be7c3161f89752c1428146846fe06ca63db
Reviewed-on: https://go-review.googlesource.com/c/build/+/279512
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 23, 2020

Change https://golang.org/cl/280052 mentions this issue: ipv6: skip known-failing tests on OpenBSD 6.8 builders

gopherbot pushed a commit to golang/net that referenced this issue Dec 24, 2020
These tests are known to be failing on OpenBSD 6.8 and need
investigation. The OpenBSD 6.8 builders are default TryBots
now, so skip them to prevent people working on other packages
from constantly getting a failure.

Issue 42064 remains open to do the work of determining if the
ipv6 package needs to be fixed, or if OpenBSD 6.8 has a problem
and the test can be permanently skipped as unsupported.

For golang/go#11811.
Updates golang/go#42064.
Updates golang/go#35712.

Change-Id: I59883384e4dbce679cb1a4e8e2c3f0fa7983010b
Reviewed-on: https://go-review.googlesource.com/c/net/+/280052
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur dmitshur changed the title x/net/ipv6: TestPacketConnReadWriteMulticastUDP failing with "i/o timeout" on OpenBSD builders x/net/ipv6: TestPacketConnReadWriteMulticast{UDP,ICMP} failing with "i/o timeout" on OpenBSD 6.8 Dec 24, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Dec 24, 2020

@4a6f656c Do openbsd-{arm,arm64,mips64}-jsing builders all run OpenBSD 6.8? If not, the issue title may need to be adjusted further.

@toothrot
Copy link
Contributor

@toothrot toothrot commented Jan 7, 2021

@4a6f656c Just a friendly ping on this release-blocker in the new year. Do you have any updates?

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Jan 13, 2021

@4a6f656c Have there been any updates with this issue. We are approaching the release and this is a release-blocker.

@tklauser
Copy link
Member

@tklauser tklauser commented Jan 14, 2021

I quickly checked the arm64 and mips64 builders using gomote (the arm builder seems to be offline). They seem to be running OpenBSD 6.8 (uname -a output):

openbsd-arm64-jsing:
OpenBSD gopher-arm64.sing.id.au 6.8 GENERIC.MP#2 arm64

openbsd-mips64-jsing:
OS: OpenBSD er4.sing.id.au 6.8 GENERIC.MP#0 octeon

Assuming that the offline openbsd-arm-jsing builder also runs at least 6.7 (see #25498 (comment)) and that OpenBSD version might be affected the same, I've sent https://golang.org/cl/283752 to include openbsd-{arm,arm64,mips64}-jsing in the list of builders to skip the test on.

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 14, 2021

Change https://golang.org/cl/283752 mentions this issue: ipv6: skip known-failing tests on openbsd-{arm,arm64,mips64}-jsing builders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.