Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
x/build: improve trybot aliases for ppc64 #42067
I frequently see changes being made to code related to PPC64 which only use TRY=ppc64 for testing those changes. While I understand that this seems like the right default for code related to ppc64, this actually runs only the linux-ppc64 trybot, which tests only big endian and has limited linking capabilities (internal linking only, no cgo, no others like plug-ins or pie). So this selection is not the best default and does not provide good coverage for PPC64 testing.
I understand the naming is unfortunate because in the Go source code PPC64 usually used as a general term for code generation that applies to linux-ppc64, linux-ppc64le, linux-ppc64le-power9, and aix-ppc64.
Could we change the ppc64 alias in build/dashboard/builders.go to run the linux-ppc64le buildlet? This is really the most commonly used Power target for Go and provides the most linking capability. If someone REALLY wanted to run ppc64 big endian they could still use the linux-ppc64 alias.
I'd also like to have an alias for ppc64le on power9, maybe ppc64lep9.
I could make the change but I don't know how to test it. @dmitshur
We currently have the following aliases related to ppc64:
I think longer aliases need to be precise, and "linux-ppc64", "linux-ppc64le" should get the expected builder. But a short alias such as "ppc64" can be modified to point to the builder we think is most fitting. (Ideally, in the future, "ppc64" should expand to multiple builders to provide sufficient coverage, and people can use a longer alias if they want a very specific single builder.)
We should remove "ppc64le" to avoid or making it seem like "ppc64" gets the big endian one.
Given that it's an alias for a specific target, how about "linux-ppc64le-power9" to be more clear and consistent?
@laboger Do you mind sending a mail to golang-dev@ to notify people who rely on PPC64 aliases about this change and direct them to this issue if they want to express support for it or share concerns? It'd be helpful to get some more feedback from others before we make a change to slowbot aliases.
Also CC @golang/release.
Thanks, I agree with all your suggestions, especially at some point to have one keyword to run all 4 variations. I will send a note to golang-dev to gather more opinions.
Sound good, thanks for doing that.
I've remembered that we have a test that ensures each GOOS, GOARCH term has some slowbot alias. But given how similar
One other suggestion, although maybe this belongs in a different issue. If I have a CL and specify a new TRY list, it doesn't rerun the trybots unless the CL has changed since the last TRY (at least that appears to be the way it works.) It seems that if a new TRY list is specified it should rerun it?