Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add regtests for multiple workspace folders #42111

Open
stamblerre opened this issue Oct 21, 2020 · 3 comments
Open

x/tools/gopls: add regtests for multiple workspace folders #42111

stamblerre opened this issue Oct 21, 2020 · 3 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Oct 21, 2020

We currently have no test coverage for multiple workspace folders (not using experimentalWorkspaceModule). We can add a new mode to the regression tests to cover this case.

@stamblerre stamblerre added this to the gopls/vscode-go milestone Oct 21, 2020
@stamblerre stamblerre added the Soon label Oct 29, 2020
@findleyr findleyr self-assigned this Nov 10, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 10, 2020

Change https://golang.org/cl/257138 mentions this issue: gopls/internal/regtest: add an option to nest the workdir

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Nov 10, 2020

Reopening because this isn't just for nested modules--we need to add tests for multiple workspace folders, each containing a module.

@stamblerre stamblerre reopened this Nov 10, 2020
@stamblerre stamblerre changed the title x/tools/gopls: add a regtest mode for multiple workspace folders x/tools/gopls: add regtests for multiple workspace folders Nov 10, 2020
@findleyr
Copy link
Contributor

@findleyr findleyr commented Nov 10, 2020

Ah, wrong issue. My bad!

@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre added the Testing label Nov 10, 2020
@stamblerre stamblerre moved this from Critical to In progress in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from In progress to Testing in vscode-go: gopls by default Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.