Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
x/net/http2: the first write error on a connection will cause all subsequent write requests to fail blindly [1.14 backport] #42112
…rors When a new connection is created, and a write error occurs during the initial exchange, the connection must be closed. There is no guarantee that the caller will close the connection. When a connection with an existing write error is used or being used, it will stay in use until its read loop completes. Requests will continue to use this connection and fail when writing its header. These connections should be closed to force the cleanup in its readLoop. Updates golang/go#39337. For golang/go#42112. Change-Id: I45e1293309e40629531f4cbb69387864f4f71bc2 Reviewed-on: https://go-review.googlesource.com/c/net/+/240337 Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org> Run-TryBot: Brad Fitzpatrick <email@example.com> TryBot-Result: Go Bot <firstname.lastname@example.org> Trust: Brad Fitzpatrick <email@example.com> Trust: Damien Neil <firstname.lastname@example.org> (cherry picked from commit f585440) Reviewed-on: https://go-review.googlesource.com/c/net/+/266157 Trust: Dmitri Shuralyov <email@example.com> Run-TryBot: Dmitri Shuralyov <firstname.lastname@example.org> Reviewed-by: Michael Fraenkel <email@example.com> Reviewed-by: Alexander Rakoczy <firstname.lastname@example.org>
Bring in the change in CL 266157 with: go get -d email@example.com go mod tidy go mod vendor go generate -run=bundle std Updates #39337. Fixes #42112. Change-Id: Iefd0012369c7f0c58201256e29d21210cb9f2f7a Reviewed-on: https://go-review.googlesource.com/c/go/+/266374 Run-TryBot: Dmitri Shuralyov <firstname.lastname@example.org> Reviewed-by: Emmanuel Odeke <email@example.com> TryBot-Result: Go Bot <firstname.lastname@example.org> Trust: Dmitri Shuralyov <email@example.com>