Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: register semantic tokens with textDocument/semanticTokens #42148

Closed
stamblerre opened this issue Oct 22, 2020 · 4 comments
Closed

x/tools/gopls: register semantic tokens with textDocument/semanticTokens #42148

stamblerre opened this issue Oct 22, 2020 · 4 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Oct 22, 2020

We currently use textDocument/semanticTokens/full only, but the correct way is textDocument/semanticTokens. We'll have to register semantic tokens both ways to avoid regressing, but we'll eventually be able to remove the multiple registration capabilities after the next VS Code Go release.

This will depend on the release of the next version of the vscode-languageclient. See microsoft/language-server-protocol#1107 for context.

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 30, 2020

Change https://golang.org/cl/266497 mentions this issue: package.json: upgrade to the latest vscode-languageclient pre-release

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 30, 2020

Change https://golang.org/cl/266479 mentions this issue: internal/lsp: use the correct method name to register semantic tokens

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Oct 30, 2020

Leaving this open after https://golang.org/cl/266479 to track the deletion of the semanticTokenRegistrations function.

gopherbot pushed a commit to golang/tools that referenced this issue Oct 30, 2020
Leave the legacy names to handle old versions of the VS Code language
client.

Updates golang/go#42148

Change-Id: Ia3eeef9e792e502c5c8018698b9c0ea3a9b0dfe5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/266479
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Peter Weinberger <pjw@google.com>
@stamblerre stamblerre reopened this Oct 30, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 13, 2020
@stamblerre stamblerre moved this from Needs Triage to Non-critical in vscode-go: gopls by default Nov 13, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 16, 2020

Change https://golang.org/cl/270359 mentions this issue: internal/lsp: fix capability registration for semantic tokens

vscode-go: gopls by default automation moved this from Non-critical to Done Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.