Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: Location interprets wrong timezone (DST) with slim zoneinfo [1.14 backport] #42155

Closed
gopherbot opened this issue Oct 22, 2020 · 7 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 22, 2020

@ianlancetaylor requested issue #42138 to be considered for backport to the next 1.14 minor release.

@gopherbot Please open backport for 1.14.

Without a backport people using Go 1.14 with a new tzdata installation will not get the correct timezone information.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 22, 2020

Change https://golang.org/cl/264302 mentions this issue: [release-branch.go1.14] time: use extended time format past end of zone transitions

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 29, 2020

Approving per discussion in a release meeting. This is a serious issue without a workaround. This backport applies to both 1.15 (#42138) and 1.14 (this issue).

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 29, 2020

Closed by merging 1f040e0 to release-branch.go1.14.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 29, 2020

Change https://golang.org/cl/266298 mentions this issue: [release-branch.go1.14] time: support slim tzdata format

gopherbot pushed a commit that referenced this issue Oct 29, 2020
…ne transitions

This gives us better expected information for daylight savings time
transitions in year 2038 and beyond.

For #36654
For #42155

Change-Id: I5a39aed3c40b184e1d7bb7d6ce3aff5307c4c146
Reviewed-on: https://go-review.googlesource.com/c/go/+/215539
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit b71eafb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/264302
Trust: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 29, 2020

We usually do minor releases at the start of each month, so, if all goes well, next week.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 29, 2020

Change https://golang.org/cl/266303 mentions this issue: [release-branch.go1.14] time: fix LoadLocationFromTZData with slim tzdata

gopherbot pushed a commit that referenced this issue Oct 29, 2020
Backport of part of https://golang.org/cl/261877 to support the slim
tzdata format. As of tzdata 2020b, the default is to use the slim format.
We need to support that format so that Go installations continue to
work when tzdata is updated.

Relevant part of the CL description:

    The reason for the failed tests was that when caching location data, the
    extended time format past the end of zone transitions was not
    considered. The respective change was introduced in (*Location).lookup
    by CL 215539.

For #42155

Change-Id: I37f52a0917b2c6e3957e6b4612c8ef104c736e65
Reviewed-on: https://go-review.googlesource.com/c/go/+/264301
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
(cherry picked from commit 414668c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/266298
Run-TryBot: Ian Lance Taylor <iant@golang.org>
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 29, 2020

The 1.14 branch should now support slim tzdata files.

gopherbot pushed a commit that referenced this issue Oct 29, 2020
…data

The extend information of a time zone file with last transition < now
could result in a wrong cached zone because it used the zone of the
last transition.

This could lead to wrong zones in systems with slim zoneinfo.

Fixes #42155

Change-Id: I7c57c35b5cfa58482ac7925b5d86618c52f5444d
Reviewed-on: https://go-review.googlesource.com/c/go/+/264939
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 70e022e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/266303
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.