Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: the Server.Shutdown listener polling interval causes shutdown delay #42156

Closed
danp opened this issue Oct 22, 2020 · 2 comments
Closed

net/http: the Server.Shutdown listener polling interval causes shutdown delay #42156

danp opened this issue Oct 22, 2020 · 2 comments
Milestone

Comments

@danp
Copy link
Contributor

@danp danp commented Oct 22, 2020

The fix for #33313 ensured that Shutdown waits for listeners to be closed but uses a fixed polling interval of 500ms. This causes Shutdown to almost always take at least 500ms which can be noticeable in interactive contexts.

It would be nice if the polling started with a small interval and backed off to 500ms or so.

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 22, 2020

Change https://golang.org/cl/264479 mentions this issue: net/http: use polling interval backoff in Server.Shutdown

@cagedmantis cagedmantis added this to the Backlog milestone Oct 23, 2020
@cagedmantis cagedmantis changed the title net/http: Server.Shutdown listener polling causes shutdown delay net/http: the Server.Shutdown listener polling interval causes shutdown delay Oct 23, 2020
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Oct 23, 2020

/cc @mikioh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants