Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: trace of error response is missing #42157

Open
hyangah opened this issue Oct 22, 2020 · 0 comments
Open

x/tools/gopls: trace of error response is missing #42157

hyangah opened this issue Oct 22, 2020 · 0 comments

Comments

@hyangah
Copy link
Contributor

@hyangah hyangah commented Oct 22, 2020

I triggered a codeAction that will fail and couldn't find the matching "Received response ..." from gopls trace.
The 'Error' entry is from vscode client (in response of the error reply) and doesn't include the message id. This makes it difficult for trace viewer to process the trace.

[Trace - 18:36:44.832 PM] Sending request 'textDocument/codeAction - (8)'.
Params: {"textDocument":{"uri":"file:///Users/hakim/hello/b.go"},"range":{"start":{"line":0,"character":1},"end":{"line":0,"character":1}},"context":{"diagnostics":[]}}

...
[Error - 6:36:44 PM] Request textDocument/codeAction failed.
  Message: no packages returned: packages.Load error
  Code: 0 

The following is the corresponding trace recorded from the client side.

[Trace - 6:36:44 PM] Sending request 'textDocument/codeAction - (8)'.
Params: {
    "textDocument": {
        "uri": "file:///Users/hakim/hello/b.go"
    },
    "range": {
        "start": {
            "line": 0,
            "character": 1
        },
        "end": {
            "line": 0,
            "character": 1
        }
    },
    "context": {
        "diagnostics": []
    }
}
...
[Trace - 6:36:44 PM] Received response 'textDocument/codeAction - (8)' in 39ms. Request failed: no packages returned: packages.Load error (0).
@gopherbot gopherbot added this to the Unreleased milestone Oct 22, 2020
@findleyr findleyr self-assigned this Oct 23, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Critical to In progress in vscode-go: gopls by default Nov 10, 2020
@findleyr findleyr moved this from In progress to Non-critical in vscode-go: gopls by default Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.