Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile, runtime, reflect: pointers to go:notinheap types must be stored indirectly in interfaces [1.15 backport] #42169

Closed
gopherbot opened this issue Oct 23, 2020 · 2 comments
Closed

cmd/compile, runtime, reflect: pointers to go:notinheap types must be stored indirectly in interfaces [1.15 backport] #42169

gopherbot opened this issue Oct 23, 2020 · 2 comments
Labels
CherryPickApproved FrozenDueToAge release-blocker
Milestone
Go1.15.4

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 23, 2020

@randall77 requested issue #42076 to be considered for backport to the next 1.15 minor release.

@gopherbot Please open a backport issue for 1.15.
@gopherbot gopherbot mentioned this issue Oct 23, 2020
Closed
@gopherbot gopherbot added this to the Go1.15.4 milestone Oct 23, 2020
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 27, 2020

Change https://golang.org/cl/265720 mentions this issue: cmd/compile, runtime: store pointers to go:notinheap types indirectly

Loading

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 27, 2020

Closed by merging 255afa2 to release-branch.go1.15.

Loading

@gopherbot gopherbot closed this Oct 27, 2020
gopherbot pushed a commit that referenced this issue Oct 27, 2020
@randall77 @ianlancetaylor
[release-branch.go1.15] cmd/compile, runtime: store pointers to go:no…
255afa2 
…tinheap types indirectly

pointers to go:notinheap types should be treated as scalars. That
means they shouldn't be stored directly in interfaces, or directly
in reflect.Value.ptr.

Also be sure to use uintpr to compare such pointers in reflect.DeepEqual.

Fixes #42169

Change-Id: I53735f6d434e9c3108d4940bd1bae14c61ef2a74
Reviewed-on: https://go-review.googlesource.com/c/go/+/264480
Trust: Keith Randall <khr@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 009d714)
Reviewed-on: https://go-review.googlesource.com/c/go/+/265720
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.15.4
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@toothrot @randall77 @gopherbot