Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: look for CLs with +2 but no Trust+1 #42176

Open
ianlancetaylor opened this issue Oct 23, 2020 · 6 comments
Open

release: look for CLs with +2 but no Trust+1 #42176

ianlancetaylor opened this issue Oct 23, 2020 · 6 comments
Assignees
Milestone

Comments

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 23, 2020

As part of the transition to the release freeze, we should look for CLs that have a +2 but no Trust+1. Those CLs should all be reviewed for Trust+1 purposes, and, if no problems are found, submitted.

CC @dmitshur @cagedmantis @toothrot

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 23, 2020

@toothrot has previously suggested this Gerrit search query:

https://go-review.googlesource.com/q/label:Code-Review%253D%252B2+label:Untrusted%253Dreject

There are 3.5~ pages of results (at 25 CL/page) at this time.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 23, 2020

https://go-review.googlesource.com/q/label:Code-Review%253D%252B2+label:Untrusted%253Dreject+repo:go+branch:master+-label:Code-Review%253D-2+-hashtag:wait-author narrows it down to just the main repository, main branch, no -2 vote, no wait-author hashtag. There are 58 matching open CLs at time of posting.

@cagedmantis cagedmantis added this to the Go1.16 milestone Oct 23, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 4, 2020

Many CLs have been submitted since last time. I've looked over some of them and reviewed for Trust where it was the only missing thing. By now, the same query finds 15 CLs (down from 58). Many of those 15 have remaining work or need attention from someone, although maybe not all.

@toothrot toothrot self-assigned this Nov 5, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 10, 2020

The query above (slightly modified to additionally filter out CLs that are waiting on author or have a -2 review) by now finds only 8 CLs. Of those, 6 are sent by people who have the ability to grant Trust+1 themselves. The other 2 were being actively evaluated for readiness for submission.

Given we're in the freeze and the week to submit in-flight changes has passed, I don't think there's more to do here.

@dmitshur dmitshur closed this Nov 10, 2020
@dmitshur dmitshur self-assigned this Nov 10, 2020
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Nov 10, 2020

I was hoping that this issue would become a recurring issue that we kept open for each release.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 10, 2020

@cagedmantis I was previously thinking this was needed for the Go 1.16 release only because the Trust requirement is new, and some CLs that could previously be submitted now needed an extra vote. But it does seem such a situation can continue to happen in the future if a CL is sent by someone without ability to self-Trust+1, and reviewed only with a single Code-Review+2. Thanks for pointing this out.

Maybe in the future this can be factored out to happen continuously as part of normal code review and not need to be tied as closely to the start of the release freeze, but I guess it'll work to make this issue recurring until that happens.

@dmitshur dmitshur reopened this Nov 10, 2020
@dmitshur dmitshur removed their assignment Nov 10, 2020
@dmitshur dmitshur added the recurring label Nov 10, 2020
@dmitshur dmitshur modified the milestones: Go1.16, Go1.17 Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.