Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: darwin builders failing on metrics changes #42218

Closed
prattmic opened this issue Oct 26, 2020 · 3 comments
Closed

runtime: darwin builders failing on metrics changes #42218

prattmic opened this issue Oct 26, 2020 · 3 comments

Comments

@prattmic
Copy link
Member

@prattmic prattmic commented Oct 26, 2020

All of the darwin builders are failing on one of the metrics changes that just went in.

The failing commit is one of golang.org/cl/246971, golang.org/cl/246972, golang.org/cl/246973.

I am attempting to repro on a gomote.

cc @mknyszek @aclements @golang/release

@prattmic prattmic added this to the Go1.16 milestone Oct 26, 2020
@dmitshur dmitshur added the Soon label Oct 26, 2020
@prattmic
Copy link
Member Author

@prattmic prattmic commented Oct 26, 2020

https://golang.org/cl/246971 is the specific failing CL.

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 26, 2020

Change https://golang.org/cl/265157 mentions this issue: runtime: make sysMemStats' methods nosplit

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 26, 2020

Change https://golang.org/cl/265158 mentions this issue: runtime: revert commits 8ebc58..a8b28eb

@gopherbot gopherbot closed this in 22d2b98 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.