Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: use a per-process shared temp directory #42252

Open
findleyr opened this issue Oct 28, 2020 · 2 comments
Open

x/tools/gopls: use a per-process shared temp directory #42252

findleyr opened this issue Oct 28, 2020 · 2 comments

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented Oct 28, 2020

gopls can generate a fairly wide-range of temp files and directories (logs, heap dumps, temp modfiles, gc details data, and now temp workspace directories).

We should consolidate these into a top-level temp directory for the gopls process, both so that they are co-located, and so that we can have a catch-all clean up pass when the gopls process exits.

@gopherbot gopherbot added this to the Unreleased milestone Oct 28, 2020
@heschik
Copy link
Contributor

@heschik heschik commented Oct 29, 2020

I think this is generally good, but we want the memory debug zips to be discoverable. IMO either the temp dirs should be predictably named, or the debug zips should stay at the top level.

@findleyr
Copy link
Contributor Author

@findleyr findleyr commented Oct 29, 2020

I was imagining /tmp/gopls-<pid>/, which could contain trace.log, stderr.log, details/, workspace/, 1GB-nonames.zip, for example.

@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Non-critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Non-critical to Needs Triage in vscode-go: gopls by default Nov 11, 2020
@stamblerre stamblerre moved this from Needs Triage to Non-critical in vscode-go: gopls by default Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.