Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: failures in TestTxStmtDeadlock starting Oct. 28 #42259

Closed
bcmills opened this issue Oct 28, 2020 · 3 comments
Closed

database/sql: failures in TestTxStmtDeadlock starting Oct. 28 #42259

bcmills opened this issue Oct 28, 2020 · 3 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Oct 28, 2020

--- FAIL: TestTxStmtDeadlock (0.01s)
    sql_test.go:2835: unexpected error while executing stmt, err: sql: statement is closed
FAIL
FAIL	database/sql	0.624s

Possibly due to CL 250178 (@tz70s, @odeke-em @kardianos).
(Possibly another deadlock similar to the one fixed in that CL.)

Marking as release-blocker because deadlock and test-regression.

2020-10-28T19:19:04-bc0d7fd/freebsd-amd64-12_0
2020-10-28T16:55:17-d4c1ad8/openbsd-386-64

@kardianos
Copy link
Contributor

@kardianos kardianos commented Oct 28, 2020

@bcmills Sorry. My fault. I'll look into ASAP.

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 28, 2020

Change https://golang.org/cl/266097 mentions this issue: database/sql: fix TestTxStmtDeadlock test

@tz70s
Copy link
Contributor

@tz70s tz70s commented Oct 28, 2020

Yes sorry was due to one error check I wasn't aware of, the test was introduced by that CL as well instead of existing regression.

@gopherbot gopherbot closed this in d8044a6 Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.