x/tools/gopls: make vet analyzers consistent with cmd/vet

[smasher164]

What did you do?

I compared the vet analyzers listed in internal/lsp/source/options.go for v0.5.2 with those listed in cmd/vet/main.go for v1.14:

What did you expect to see?

That they were the same.

What did you see instead?

--- gopls.txt
+++ vet.txt
@@ -1,7 +1,6 @@
 asmdecl.Analyzer,
 assign.Analyzer,
 atomic.Analyzer,
-atomicalign.Analyzer,
 bools.Analyzer,
 buildtag.Analyzer,
 cgocall.Analyzer,
@@ -9,12 +8,14 @@ composite.Analyzer,
 copylock.Analyzer,
 errorsas.Analyzer,
 httpresponse.Analyzer,
+ifaceassert.Analyzer,
 loopclosure.Analyzer,
 lostcancel.Analyzer,
 nilfunc.Analyzer,
 printf.Analyzer,
 shift.Analyzer,
 stdmethods.Analyzer,
+stringintconv.Analyzer,
 structtag.Analyzer,
 tests.Analyzer,
 unmarshal.Analyzer,

ifaceassert.Analyzer and stringintconv.Analyzer need to be added, and IIRC atomicalign.Analyzer isn't part of vet.

Build info

golang.org/x/tools/gopls v0.5.2
    golang.org/x/tools/gopls@v0.5.2 h1:lyHTekqy0QhXzz5hDFnfMGHk0Qmuq+LWH5VN/o19YLk=
    github.com/BurntSushi/toml@v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
    github.com/google/go-cmp@v0.5.1 h1:JFrFEBb2xKufg6XkJsJr+WbKb4FQlURi5RUcBveYu9k=
    github.com/sergi/go-diff@v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
    golang.org/x/mod@v0.3.0 h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=
    golang.org/x/sync@v0.0.0-20200625203802-6e8e738ad208 h1:qwRHBd0NqMbJxfbotnDhm2ByMI1Shq4Y6oRJo21SGJA=
    golang.org/x/tools@v0.0.0-20201028153306-37f0764111ff h1:TU04fJ6/hxmk+6BeFPKM3iuCGqj0ep6ghDdEdhN1cnk=
    golang.org/x/xerrors@v0.0.0-20200804184101-5ec99f83aff1 h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
    honnef.co/go/tools@v0.0.1-2020.1.5 h1:nI5egYTGJakVyOryqLs1cQO5dO0ksin5XXs2pspk75k=
    mvdan.cc/gofumpt@v0.0.0-20200802201014-ab5a8192947d h1:t8TAw9WgTLghti7RYkpPmqk4JtQ3+wcP5GgZqgWeWLQ=
    mvdan.cc/xurls/v2@v2.2.0 h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=

[gopherbot]

Change https://golang.org/cl/266058 mentions this issue: internal/lsp/source: add missing vet analyzers

[stamblerre]

Thanks for the report! Just sent out a change to fix this.