Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: save old metadata before invalidating #42266

Open
stamblerre opened this issue Oct 29, 2020 · 0 comments
Open

x/tools/gopls: save old metadata before invalidating #42266

stamblerre opened this issue Oct 29, 2020 · 0 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Oct 29, 2020

We currently invalidate metadata before reloading, so we may lose metadata if something has changed an a given package is now unloadable. We should instead follow the approach taken in https://golang.org/cl/261237, and invalidate metadata only after we've successfully reloaded it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.