Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: [beta] module pages have extra links in ... menu #42298

Closed
prattmic opened this issue Oct 30, 2020 · 1 comment
Closed

x/pkgsite: [beta] module pages have extra links in ... menu #42298

prattmic opened this issue Oct 30, 2020 · 1 comment
Assignees
Labels

Comments

@prattmic
Copy link
Member

@prattmic prattmic commented Oct 30, 2020

What is the URL of the page with the issue?

https://beta.pkg.go.dev/mod/gvisor.dev/gvisor

What is your user agent?

Mozilla/5.0 (X11; CrOS x86_64 13421.53.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.77 Safari/537.36

This bug only appears on the mobile site. I've clicked the little 'mobile mode' button in the dev tools for these screenshots. I first noticed this issue on Chrome for Android.

Screenshot

Screenshot 2020-10-30 at 11 48 43

Upon scrolling, we get a "..." menu that contains links like "Imports".

Later, I navigated to another page and wanted to access "Imports", but I'm presented with this:

Screenshot 2020-10-30 at 11 50 40

Where is "Imports"? Maybe in the hamburger menu in the upper right (same location as the ... after scroll)?

Screenshot 2020-10-30 at 11 51 53

Nope! :(

What did you expect to see?

This had me a bit confused for a while about how to get to "Imports". I actually ended up scrolling down just so I could access the ... menu.

Later I realized that this is a module and thus can't have imports. If this was a packages, the imports would appear at the top with the version/license.

For consistency, I think that either the ... menu should exclude "Imports" and "Imported By" on module pages, or module pages should include "Imports" and "Imported By" links next to version/license. i.e., these items should either be included in both locations or excluded in both locations.

@gopherbot gopherbot added the pkgsite label Oct 30, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 30, 2020
@jamalc jamalc self-assigned this Oct 30, 2020
@jamalc jamalc added the NeedsFix label Oct 30, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 6, 2020

Change https://golang.org/cl/267938 mentions this issue: internal/frontend: add tab settings config for directories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants