Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: incorrectly identifies sub-module #42346

Open
codyoss opened this issue Nov 2, 2020 · 4 comments
Open

x/pkgsite: incorrectly identifies sub-module #42346

codyoss opened this issue Nov 2, 2020 · 4 comments

Comments

@codyoss
Copy link
Member

@codyoss codyoss commented Nov 2, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/cloud.google.com/go?tab=subdirectories

Screenshot

Screen Shot 2020-11-02 at 11 14 47 AM

What did you do?

Navigate to the page linked above.

What did you expect to see?

cloud.google.com/go/compute/metadata NOT listed as a sub-module.

What did you see instead?

cloud.google.com/go/compute/metadata listed as a sub-module.

It was it's own module at one point, but it is no longer and has not been for many releases.

@gopherbot gopherbot added the pkgsite label Nov 2, 2020
@gopherbot gopherbot added this to the Unreleased milestone Nov 2, 2020
@jba jba modified the milestones: Unreleased, pkgsite/unplanned Nov 2, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Nov 4, 2020

It was it's own module at one point, but it is no longer and has not been for many releases.

We could dedupe the list of nested modules and packages for a given page, and not list the nested module if it is a package in that module.

On https://beta.pkg.go.dev/cloud.google.com/go@v0.71.0, compute/metadata is listed as both a package and a nested module.

image

image

@julieqiu julieqiu added the help wanted label Nov 4, 2020
@trongbq
Copy link

@trongbq trongbq commented Nov 9, 2020

@julieqiu I can help on this one.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Nov 9, 2020

Thanks, @trongbq!

@trongbq
Copy link

@trongbq trongbq commented Nov 23, 2020

@julieqiu

We could dedupe the list of nested modules and packages for a given page, and not list the nested module if it is a package in that module.

I think that is not a good approach to solve this issue. This issue happens because somehow pkgsite falsely identified compute/metadata as both package and module, but as issue states that with newer versions, compute/metadata is no longer a module.
Should we look for the fix in worker fetch instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.