Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: explicitly watch for directories in file watching #42348

Closed
stamblerre opened this issue Nov 2, 2020 · 3 comments
Closed

x/tools/gopls: explicitly watch for directories in file watching #42348

stamblerre opened this issue Nov 2, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Nov 2, 2020

See microsoft/vscode#109754 for context.

VS Code requires that we watch directories explicitly--a deletion of a directory that contains Go files will not give us a notification if our glob pattern only contains Go files. A glob pattern of "**" would work, but this would watch every file in the workspace, including non-Go files that we do not care about. It seems like we have to explicitly watch for every directory in the workspace that contains Go files.

@stamblerre stamblerre added this to the gopls/v0.5.3 milestone Nov 2, 2020
@stamblerre stamblerre self-assigned this Nov 2, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 3, 2020

Change https://golang.org/cl/267120 mentions this issue: internal/lsp: explicitly watch all known directories

@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Critical to In progress in vscode-go: gopls by default Nov 10, 2020
vscode-go: gopls by default automation moved this from In progress to Done Nov 17, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 17, 2020

Change https://golang.org/cl/270799 mentions this issue: internal/lsp: explicitly watch all known directories""

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 19, 2020

Change https://golang.org/cl/271438 mentions this issue: internal/lsp: explicitly watch all known directories

@stamblerre stamblerre reopened this Nov 19, 2020
vscode-go: gopls by default automation moved this from Done to In progress Nov 19, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.4, gopls/v0.6.0 Nov 24, 2020
vscode-go: gopls by default automation moved this from In progress to Done Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.