Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: missing struct docs #42425

Open
codyoss opened this issue Nov 6, 2020 · 2 comments
Open

x/pkgsite: missing struct docs #42425

codyoss opened this issue Nov 6, 2020 · 2 comments
Assignees
Labels

Comments

@codyoss
Copy link
Member

@codyoss codyoss commented Nov 6, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/google.golang.org/genproto/googleapis/cloud/secretmanager/v1#Secret

Screenshot

pkg.go.dev:
Screen Shot 2020-11-06 at 8 29 32 AM

godoc.org:

Screen Shot 2020-11-06 at 8 30 29 AM

What did you do?

Navigate to pkg.go.dev to look up some docs.

What did you expect to see?

Struct field docs.

What did you see instead?

No documentation. Here is the source for the docs: source.

@gopherbot gopherbot added the pkgsite label Nov 6, 2020
@gopherbot gopherbot added this to the Unreleased milestone Nov 6, 2020
@jba jba added the NeedsFix label Nov 6, 2020
@jba jba self-assigned this Nov 6, 2020
@jba jba modified the milestones: Unreleased, pkgsite/unplanned Nov 6, 2020
@jba
Copy link
Contributor

@jba jba commented Nov 6, 2020

Thanks for finding this. I first feared that it was a bug in some recent work we've been doing on documentation rendering, but it actually predates that. It's related to that long field tag on Labels: overly long field tags turn off all other comments in a declaration. Should have a fix by Monday.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 7, 2020

I think this is related to #38699. This seems like a slightly different type of occurrence (one where godoc.org isn’t affected), but the root problem might be the same. I started working on a fix for it in CL 240217, although there’s a merge conflict to resolve by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.