Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc, x/build/dashboard: document Go 1.16 requires at least OpenBSD 6.4, drop OpenBSD 6.2 builders #42426

Open
dmitshur opened this issue Nov 6, 2020 · 4 comments

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 6, 2020

Based on investigation and discussion in #42237 and #42408, and past support policy discussion in #15227 (comment), we should drop OpenBSD 6.2 support from the upcoming Go 1.16 release. What's needed:

  • Disable openbsd-{386,amd64}-62 builders for Go 1.16 and newer.
  • Document in Go 1.16 release notes that Go 1.16 requires at least OpenBSD 6.4: "Go 1.15 was the last release that ran on OpenBSD 6.2. Go 1.16 requires OpenBSD 6.4 or newer."
    • Ideally we should say OpenBSD 6.7 or newer, but we don't have builders to back up such a claim (see #35712), so I think this is the best we can say for now.
    • Ideally we would've pre-announced this earlier, like in Go 1.11 release notes. Unfortunately we didn't have the information we have now earlier.
  • Update relevant golang.org/wiki pages as needed.

Please comment if you think this plan can be improved.

CC @golang/release, @ianlancetaylor, @4a6f656c, @prattmic, @bcmills.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 6, 2020

Change https://golang.org/cl/268097 mentions this issue: cmd/dist: skip static testtls on OpenBSD 6.2 and earlier

@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Nov 10, 2020

There seems to be agreement to move forward with this plan, so moving this issue to NeedsFix.

@dmitshur dmitshur added NeedsFix and removed NeedsDecision labels Nov 10, 2020
@dmitshur dmitshur self-assigned this Nov 10, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 10, 2020

Change https://golang.org/cl/268880 mentions this issue: dashboard: only run openbsd-{386,amd64}-62 builders on Go 1.15 and older

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 12, 2020

Change https://golang.org/cl/269577 mentions this issue: dashboard: add OpenBSD 6.8 builders

gopherbot pushed a commit to golang/build that referenced this issue Nov 12, 2020
For golang/go#42426.

Change-Id: Id8a87ef1952291e06f0076f27ae019bf7ef0e6a2
Reviewed-on: https://go-review.googlesource.com/c/build/+/268880
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Nov 12, 2020
This change builds on top of CL 268297, using the updated env script
to build OpenBSD 6.8 images, and adding new builders that use them.

This has been tested with cmd/debugnewvm on a recent Go tip commit,
as well as Go 1.15.4 and 1.14.11 commits. It passed, although there
were also some failures seen. Once the builder is added, we'll know
the test results for a wider set of commits, and can decide how to
proceed from there.

Minimize the configuration to a bare minimum. Specifically, remove
MinCPUPlatform since setting it "Intel Skylake" was found not to
have a noticeable effect on the speed of the build compared to the
zero value:

	# With MinCPUPlatform = "Intel Skylake":
	$ time debugnewvm -run-build=openbsd-amd64-68 -rev=go1.15.4
	[...]
	real	17m8.308s

	# With a zero MinCPUPlatform value:
	$ time debugnewvm -run-build=openbsd-amd64-68 -rev=go1.15.4
	[...]
	real	16m28.518s

For golang/go#35712.
Updates golang/go#42426.

Change-Id: I517a85738a034a3a4074488ccecd4408a91a4a07
Reviewed-on: https://go-review.googlesource.com/c/build/+/269577
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.