Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: lock ordering problem between sweep and mspanSpecial #42472

Closed
bcmills opened this issue Nov 10, 2020 · 2 comments
Closed

runtime: lock ordering problem between sweep and mspanSpecial #42472

bcmills opened this issue Nov 10, 2020 · 2 comments
Assignees
@mknyszek
Labels
FrozenDueToAge NeedsInvestigation release-blocker
Milestone
Go1.16

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 10, 2020 

0 : sweep 7 0x663320
1 : mspanSpecial 22 0x7fd5af0f7418
fatal error: lock ordering problem

2020-11-09T19:46:24-a2d0147/linux-amd64-staticlockranking
2020-10-31T08:31:08-12a2e72/linux-amd64-staticlockranking
2020-10-23T20:53:14-d1b1145/linux-amd64-staticlockranking

CC @danscales @mknyszek
@bcmills bcmills added this to the Go1.16 milestone Nov 10, 2020
@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Nov 10, 2020

This is a missing partial edge. It's definitely a correct ordering: this is the background sweeper queuing a finalizer or handling a memory profile sample.

Loading

@mknyszek mknyszek self-assigned this Nov 10, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 10, 2020

Change https://golang.org/cl/268857 mentions this issue: runtime: add lock rank partial order edge sweep -> mspanSpecial

Loading

@gopherbot gopherbot closed this in c68745b Nov 10, 2020
@golang golang locked and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mknyszek mknyszek

Labels
FrozenDueToAge NeedsInvestigation release-blocker
Projects
None yet
Milestone
Go1.16
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@mknyszek @bcmills @gopherbot