Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: gap below unit header is a bit large on desktop viewports #42490

Closed
andybons opened this issue Nov 10, 2020 · 3 comments
Closed

x/pkgsite: gap below unit header is a bit large on desktop viewports #42490

andybons opened this issue Nov 10, 2020 · 3 comments
Labels
NeedsFix pkgsite
Milestone
pkgsite/frontend

Comments

@andybons
Copy link
Member

@andybons andybons commented Nov 10, 2020 •
edited

See screenshot below for the area I’m talking about. I think it could be tightened up a bit.

Great job, team!

Screen Shot 2020-11-10 at 3 24 10 PM
@gopherbot gopherbot added the pkgsite label Nov 10, 2020
@gopherbot gopherbot added this to the Unreleased milestone Nov 10, 2020
@andybons andybons added the UX label Nov 10, 2020
@julieqiu julieqiu added NeedsFix and removed UX labels Nov 10, 2020
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/frontend Nov 10, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Nov 10, 2020

/cc @jamalc
@jamalc
Copy link
Member

@jamalc jamalc commented Nov 12, 2020

Oh yeah, good call. I'll take this.
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 12, 2020

Change https://golang.org/cl/269557 mentions this issue: content/static: tighten spacing below header on unit page
@gopherbot gopherbot closed this in golang/pkgsite@45ca70c Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@andybons @julieqiu @gopherbot @jamalc