Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add a second analysis diagnostics pass for changed files #42499

Open
stamblerre opened this issue Nov 11, 2020 · 1 comment
Open

x/tools/gopls: add a second analysis diagnostics pass for changed files #42499

stamblerre opened this issue Nov 11, 2020 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Nov 11, 2020

After the fix to avoid flashing diagnostics (https://golang.org/cl/267817), I now feel a noticeable lag when getting diagnostic results for files with no errors or with analysis errors. I think we should add a second pass that runs diagnostics with analyses on only the changed files, so that those results can come back before the diagnostics for the whole workspace.

/cc @findleyr

@stamblerre stamblerre added this to the gopls/v0.5.3 milestone Nov 11, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 11, 2020

Change https://golang.org/cl/269197 mentions this issue: internal/lsp: run analyses on changed files before full diagnostics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.