-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys: TestClockNanosleep failures with CLOCK_REALTIME #42513
Comments
Fix looks straightforward. The failure is always for |
Change https://golang.org/cl/363456 mentions this issue: |
Change https://golang.org/cl/383175 mentions this issue: |
The 'd' constant is intentionally set fairly long to allow for builder jitter; however, dFromDuration previously hard-coded only 1ms of downward timing slop. That slop can be introduced due to time spent between the call to WaitN in the previous runWait and the call to time.Now in the current runWait, and empirically may be a bit larger than 1ms on certain builders (especially the android-amd64-emu builders, which also have more clock drift than many other platforms; see golang/go#42513). In addition, on some BSD platforms the slop in the upward direction may actually be longer than d no matter how generously d is set. That appears to be a platform bug (see golang/go#50189). This change adjusts dFromDuration to round to the nearest d instead of biasing in one direction or the other, and allows an additional factor of slop on the affected BSD platforms. Fixes #44067 Change-Id: Id4c073bee545be2291ad98158d764e19db0160cb Reviewed-on: https://go-review.googlesource.com/c/time/+/383175 Trust: Benny Siegert <bsiegert@gmail.com> Reviewed-by: Sameer Ajmani <sameer@golang.org> Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Not clear to me whether this is a bug in
x/sys
, a bug in the test itself, or a bug in the underlying platform.2020-11-10T21:10:18-35f3e6c/android-386-emu
2020-11-06T07:34:44-80594f2/android-386-emu
2020-10-29T08:09:32-201ba4d/android-386-emu
2020-10-28T09:49:53-708e7fb/android-amd64-emu
2020-10-14T08:05:44-cc95f25/android-amd64-emu
2020-10-13T13:26:46-2da7054/android-386-emu
2020-10-08T06:45:18-c1f3e33/android-386-emu
2020-10-06T15:56:30-ac719f4/android-amd64-emu
2020-09-28T20:51:50-006507a/android-386-emu
2020-09-23T18:26:05-d9f96fd/android-amd64-emu
2020-09-18T17:44:21-af09f73/android-amd64-emu
2020-09-17T06:19:48-648f2a0/android-386-emu
2020-09-09T08:10:42-eff7692/android-386-emu
2020-08-28T19:40:41-157a740/android-386-emu
2020-08-28T08:09:24-6fcdbc0/android-386-emu
2020-08-24T13:15:25-c12d262/android-386-emu
2020-08-06T12:55:47-5acd03e/android-386-emu
2020-06-02T22:51:09-6fdc65e/android-386-emu
2020-05-19T10:57:57-fe76b77/android-386-emu
2020-04-28T19:36:00-3771e69/android-amd64-emu
2020-03-21T13:42:03-328b4cd/android-amd64-emu
CC @yath @tklauser
The text was updated successfully, but these errors were encountered: