Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: uncaught JS errors on FireFox -- "Failed to execute 'close' on dialog" #42518

Open
eliben opened this issue Nov 11, 2020 · 1 comment
Open
Assignees
Labels

Comments

@eliben
Copy link
Member

@eliben eliben commented Nov 11, 2020

What is the URL of the page with the issue?

http://localhost:8080/github.com/gin-gonic/gin

What is your user agent?

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:81.0) Gecko/20100101 Firefox/81.0

Screenshot

ff

What did you do?

Press 'f' to jump to symbol, then select one of the identifiers

What did you expect to see? What did you see instead?

The jump works, but FireFox developer console prints out the error shown in the screenshot.

@gopherbot gopherbot added the pkgsite label Nov 11, 2020
@gopherbot gopherbot added this to the Unreleased milestone Nov 11, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Nov 11, 2020

/cc @jamalc

@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/frontend Nov 11, 2020
@julieqiu julieqiu added the NeedsFix label Nov 11, 2020
@julieqiu julieqiu changed the title x/pkgsite:uncaught JS errors on FireFox -- "Failed to execute 'close' on dialog" x/pkgsite: uncaught JS errors on FireFox -- "Failed to execute 'close' on dialog" Nov 11, 2020
@jamalc jamalc self-assigned this Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.