Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: TestDirFS failure on Windows due to difference in ModTime nanos when unrelated testdata files are added #42637

Open
bcmills opened this issue Nov 16, 2020 · 2 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 16, 2020

https://storage.googleapis.com/go-build-log/f31194a9/windows-386-2008_061172ea.log:

--- FAIL: TestDirFS (0.35s)
    os_test.go:2690: TestFS found errors:
        testdata/simple: mismatch:
        	entry.Info() = simple IsDir=true Mode=drwxrwxrwx Size=0 ModTime=2020-11-16 02:32:02.0111083 +0000 GMT
        	file.Stat() = simple IsDir=true Mode=drwxrwxrwx Size=0 ModTime=2020-11-16 02:32:02.012085 +0000 GMT
        
FAIL
FAIL	os	2.635s

Marking as release-blocker for Go 1.16 because DirFS is a new API.

CC @rsc @robpike @alexbrainman @networkimprov @zx2c4

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 16, 2020

I don't understand why there is a directory testdata/simple at all. Where is that coming from?

@bcmills
Copy link
Member Author

@bcmills bcmills commented Nov 17, 2020

This failure occurred in a TryBot for CL 270198. I had thought the changes in that CL were unrelated to the failure, but apparently they are somehow actually the cause of it.

@bcmills bcmills changed the title os: TestDirFS failure on Windows due to difference in ModTime nanos os: TestDirFS failure on Windows due to difference in ModTime nanos when unrelated testdata files are added Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.