Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: consider opting-in to longtest builders by default for cmd/go changes, if/when they're under 15 min #42661

Open
dmitshur opened this issue Nov 17, 2020 · 6 comments
Labels
Builders GoCommand NeedsInvestigation
Milestone

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Nov 17, 2020

(I have a feeling @bcmills may have already filed an issue for this, but I couldn't find it. Maybe it was a comment instead.)

With the progress made on #37439 (comment) recently, it seems we can speed up longtest SlowBots to run in under 15 minutes or so. If that can be done, what is your preference on enabling longtest builders by default for changes that touch the go command? CC @bcmills, @jayconrod, @matloob.

In either case, we need to wait for #37439 to be completed first, and give it a little time to see if that on its own is sufficient. But I wanted to create a tracking issue to start gathering feedback eagerly.

I'm also looking for feedback on:

  • If this is something we want to do, would you prefer that "cmd/go" changes are determined by the commit subject having the "cmd/go" path present (which is up to the author), or by looking whether any files in src/cmd/go directory are modified?

Also CC @golang/release.

@dmitshur dmitshur added Builders NeedsInvestigation GoCommand labels Nov 17, 2020
@dmitshur dmitshur added this to the Backlog milestone Nov 17, 2020
@bcmills
Copy link
Member

@bcmills bcmills commented Nov 17, 2020

(I have a feeling @bcmills may have already filed an issue for this, but I couldn't find it. Maybe it was a comment instead.)

I think it was previously an implicit subtext of #37439. Thanks for filing it as a proper issue!

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 17, 2020

If the longtest builders can be made to run at roughly the same latency as other TryBots, I think we would prefer to have them trigger by default (in much the same way that the x/tools 'bot triggers automatically).

I think we should use the same mechanism that we currently use to trigger x/tools, whatever that is. (I can't find it at the moment...)

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 21, 2020

Change https://golang.org/cl/279513 mentions this issue: dashboard: pick 4 TryBot helpers for -longtest SlowBots

gopherbot pushed a commit to golang/build that referenced this issue Dec 23, 2020
Based on the data we have so far, 4 helpers seems like a good number
to pick. It provides a balance between resource use and diminishing
returns. We may need to adjust it as future work for issue 42661,
but a first step will be to reduce overhead in accessing historical
build timing data.

Fixes golang/go#37439.
Updates golang/go#42661.

Change-Id: I1bfddf85f2dba8b42dc7b8f8749bbf45b614e93d
Reviewed-on: https://go-review.googlesource.com/c/build/+/279513
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@matloob
Copy link
Contributor

@matloob matloob commented Jan 7, 2021

This would be great! It would save me from accidentally submitting bugs in many cases...

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 15, 2021

Change https://golang.org/cl/334889 mentions this issue: cmd/go: update error messages in tests to match CL 332573

gopherbot pushed a commit that referenced this issue Jul 15, 2021
I neglected to run the 'longtest' builder, and the tests
that cover the error message changed in CL 332573 apparently
do not run in short mode.

Updates #36460
Updates #42661

Change-Id: I53500ddaca8ac9f0dfaab538923b3c9a4f71665e
Reviewed-on: https://go-review.googlesource.com/c/go/+/334889
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
steeve pushed a commit to znly/go that referenced this issue Aug 19, 2021
I neglected to run the 'longtest' builder, and the tests
that cover the error message changed in CL 332573 apparently
do not run in short mode.

Updates golang#36460
Updates golang#42661

Change-Id: I53500ddaca8ac9f0dfaab538923b3c9a4f71665e
Reviewed-on: https://go-review.googlesource.com/c/go/+/334889
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@bcmills
Copy link
Member

@bcmills bcmills commented May 3, 2022

We should also run longtest builders by default any time there are changes in src/vendor or src/cmd/vendor. We've had too many build breaks lately due to stray edits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders GoCommand NeedsInvestigation
Projects
Development

No branches or pull requests

4 participants