Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
encoding/json: SyntaxError message change breaks brittle tests #42675
The change for #36221 adds a
Filing this issue to decide whether we're sure we want to move forward with this change.
I agree. Do we have more suggestions, though?
That could be a good idea, but how would you render it in the string? If you use
Another reason not to do it is that, right now,
At this point I've learned to not try to argue with test breakages :)
To be clear, these tests are brittle and shouldn't depend on the exact text of stdlib errors. We're fine with dealing with it internally. However, 50 tests is more than we usually see break from a changed error message, which might point at this having more impact than expected in the ecosystem at large.