x/tools/gopls: semantic tokens classifies "return" and "false" as the same

[stamblerre]

return false has the same coloring for both words--the default textmate syntax highlighting has different colors for the two. I'm guessing that false is being classified as a keyword rather than a value?

/cc @pjweinb

[pjweinb]

yes. false and true are classified as keywords when they are used as pre-defined boolean constants. Typescript (and therefore semantic tokens) doesn't have any way to describe that. (iota is treated the same, for lack of anything better to do with it, although maybe it should be a readonly variable) semantic tokens handles various weird cases better than the textmate grammar var double = 4 type foo struct { iota: bool } const ( f int = iota g iota int = 4 )

…

On Tue, Nov 17, 2020 at 5:17 PM Rebecca Stambler ***@***.***> wrote: return false has the same coloring for both words--the default textmate syntax highlighting has different colors for the two. I'm guessing that false is being classified as a keyword rather than a value? [image: Screen Shot 2020-11-17 at 5 14 55 PM] <https://user-images.githubusercontent.com/5856771/99457129-797a7100-28f8-11eb-8a45-381cc096403e.png> /cc @pjweinb <https://github.com/pjweinb> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42682>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJIAI6P3F2XHHXFWVYDFS3SQLY5ZANCNFSM4TZFH2PA> .