Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: set experimentalDiagnosticsDelay to 250ms by default #42693

Open
stamblerre opened this issue Nov 18, 2020 · 4 comments
Open

x/tools/gopls: set experimentalDiagnosticsDelay to 250ms by default #42693

stamblerre opened this issue Nov 18, 2020 · 4 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Nov 18, 2020

We are still ironing out the details of this setting (https://golang.org/cl/269677 will address some of them), but eventually, it should be enabled by default.

@gopherbot gopherbot added this to the Unreleased milestone Nov 18, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default via automation Nov 18, 2020
@stamblerre stamblerre moved this from Needs Triage to Critical in vscode-go: gopls by default Nov 18, 2020
@myitcv
Copy link
Member

@myitcv myitcv commented Nov 18, 2020

Can you explain what this setting will actually do, or point me towards a CL/similar?

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Nov 18, 2020

Here are the docs for it: https://github.com/golang/tools/blob/master/gopls/doc/settings.md#experimentaldiagnosticsdelay-timeduration. Basically it's debouncing for the full workspace diagnostics--we compute the diagnostics for the changed files right away, and then wait this duration to compute diagnostics for the full workspace (reverse dependencies).

@myitcv
Copy link
Member

@myitcv myitcv commented Nov 18, 2020

Thank you very much - for some reason I didn't even think to search the option documentation (which in hindsight was silly of me).

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Nov 18, 2020

Historically, we haven't kept the docs very up-to-date, so no worries 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.