x/tools/gopls: set experimentalDiagnosticsDelay to 250ms by default #42693
Here are the docs for it: https://github.com/golang/tools/blob/master/gopls/doc/settings.md#experimentaldiagnosticsdelay-timeduration. Basically it's debouncing for the full workspace diagnostics--we compute the diagnostics for the changed files right away, and then wait this duration to compute diagnostics for the full workspace (reverse dependencies).
We've been aiming to enable diagnostic debouncing by default, and now that CL 269197 is merged, I think it's time to do that. I know that the experimental setting had it at 200ms, but the 250ms was specified in golang/go#42693, so I'm not sure which is preferable. Also, fix a bug I introduced in CL 269197, which set alwaysAnalyze to true for diagnoseChangedFiles. This should only be used for testing. Add a requirement for 1.13 to one test that relies on good overlay support (loading the file directly produced a different response from the full workspace load). Fixes golang/go#42693 Change-Id: I49b764a8d473a66a01ef0f2c6f4cbe2d512fd64e Reviewed-on: https://go-review.googlesource.com/c/tools/+/274445 Trust: Rebecca Stambler <firstname.lastname@example.org> Run-TryBot: Rebecca Stambler <email@example.com> gopls-CI: kokoro <firstname.lastname@example.org> TryBot-Result: Go Bot <email@example.com> Reviewed-by: Robert Findley <firstname.lastname@example.org>