Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: transparent TryBot retries mask stalls that should be fixed #42699

Open
bcmills opened this issue Nov 18, 2020 · 0 comments
Open

x/build: transparent TryBot retries mask stalls that should be fixed #42699

bcmills opened this issue Nov 18, 2020 · 0 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 18, 2020

I noticed a stall on a SlowBot (#39665 (comment)), and when I went to check on it again I noticed that the counter had reset and the builder had restarted.

This behavior closely mimics the js-wasm stall-and-restart behavior reported in #35170, and I wonder if it explains other observed stalls too (probably #39349; perhaps #36482 and/or #32632 as well).

This timeout-and-retry behavior seems to paper over a systemic problem to make it less noticeable, but if it were instead more noticeable we might have a better picture of how and why it occurs — and might be better equipped to fix the underlying problem (and speed up the perceived TryBot speed by eliminating the spurious timeouts entirely).

CC @golang/release

@gopherbot gopherbot added the Builders label Nov 18, 2020
@gopherbot gopherbot added this to the Unreleased milestone Nov 18, 2020
@bcmills bcmills changed the title x/build: transparent retries mask stalls that should be fixed x/build: transparent TryBot retries mask stalls that should be fixed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.