Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: use squirrel where appropriate #42708

Open
jba opened this issue Nov 18, 2020 · 4 comments
Open

x/pkgsite: use squirrel where appropriate #42708

jba opened this issue Nov 18, 2020 · 4 comments

Comments

@jba
Copy link
Contributor

@jba jba commented Nov 18, 2020

Squirrel may help with some of our dynamically constructed queries. Try it out.

@jba jba added this to the pkgsite/unplanned milestone Nov 18, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Nov 18, 2020

Thanks @johanbrandhorst for the suggestion! We got this idea from your GopherCon talk: https://www.gophercon.com/agenda/session/227419.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 20, 2020

Change https://golang.org/cl/271398 mentions this issue: internal/postgres: use squirrel in isLatestVersion

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 20, 2020

Change https://golang.org/cl/271397 mentions this issue: internal/postgres: use squirrel in GetLatestMajorVersion

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 20, 2020

Change https://golang.org/cl/271379 mentions this issue: internal/postgres: use squirrel in GetUnitMeta

gopherbot pushed a commit to golang/pkgsite that referenced this issue Nov 23, 2020
github.com/Masterminds/squirrel is now used to build the query for
GetUnitMeta.

For golang/go#42708

Change-Id: I91ce1c205739445e1bccfe9549d232b49337b999
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/271379
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
gopherbot pushed a commit to golang/pkgsite that referenced this issue Nov 24, 2020
github.com/Masterminds/squirrel is now used to build the query for
GetLatestMajorVersion.

For golang/go#42708

Change-Id: I52cc4ac0b5083040732bdf8da60495ac61426a4c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/271397
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.