Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: content overflows horizontally on startpage using safari #42718

Closed
emmanuelay opened this issue Nov 19, 2020 · 3 comments
Closed

x/pkgsite: content overflows horizontally on startpage using safari #42718

emmanuelay opened this issue Nov 19, 2020 · 3 comments

Comments

@emmanuelay
Copy link

@emmanuelay emmanuelay commented Nov 19, 2020

What is the URL of the page with the issue?

https://pkg.go.dev

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0 Safari/605.1.15

Screenshot

Skärmavbild 2020-11-19 kl  08 44 31

What did you do?

Resize the window once.

What did you expect to see?

I expected a normal responsive behavior.

What did you see instead?

Scrollbars indicating there is a horizontal overflow.
After looking through the elements of the startpage I found the culprit is in the class .Questions, more specific this style:

width: 100vw;

..when disabled, the overflow stops appearing.

@gopherbot gopherbot added the pkgsite label Nov 19, 2020
@gopherbot gopherbot added this to the Unreleased milestone Nov 19, 2020
@Omkar76
Copy link

@Omkar76 Omkar76 commented Nov 19, 2020

Seeing same issue on firefox and chrome

@Omkar76
Copy link

@Omkar76 Omkar76 commented Nov 19, 2020

The problem was caused by oversized .Questions div (faq). Removing width:100vw solved the problem. I have made a PR for the same golang/pkgsite#18

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 23, 2020

Change https://golang.org/cl/271518 mentions this issue: content/static/css: fix overflow on homepage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.