Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: diagnose go.mod error message is only a logged warning, not diagnostic #42730

Closed
stamblerre opened this issue Nov 19, 2020 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Nov 19, 2020

See https://github.com/golang/tools/blob/c0d5e8918928cb7629f88b55682d154ba05fe942/internal/lsp/diagnostics.go#L172.
We got an error report on Slack where the error message was completely swallowed and only visible in logs.

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Dec 6, 2020

I believe this has been resolved now that ErrorsForMod expands ModTidy errors to source error lists.

@stamblerre stamblerre closed this Dec 6, 2020
vscode-go: gopls by default automation moved this from Critical to Done Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants