Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: offer completions with automatic casts #42764

Open
muirdm opened this issue Nov 21, 2020 · 1 comment
Open

x/tools/gopls: offer completions with automatic casts #42764

muirdm opened this issue Nov 21, 2020 · 1 comment

Comments

@muirdm
Copy link

@muirdm muirdm commented Nov 21, 2020

var myInt int
var _ float64 = my<>

It would be nice if completing at <> offered float64(myInt) as a completion. This comes up often for me when passing an int to something that wants an int64, float64, etc. Another common case where it would be useful:

func doSomething(d time.Duration) {}

for i := 0;  < 10; i++ {
  doSomething(i<>)
}

It would be useful if <> offered time.Duration(i) to help you towards time.Duration(i) * time.Millisecond, or whatever.

Similarly, but maybe less common:

var myIntf interface{}
var _ float64 = my<>

It might be nice if completing at <> offered myIntf.(float64) as a completion. Unchecked type assertions are relatively rare, though, so perhaps not worth the effort.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 22, 2020

Change https://golang.org/cl/272286 mentions this issue: internal/lsp: offer type converted completion candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.