Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: regtest timeouts on openbsd builders #42789

Open
findleyr opened this issue Nov 23, 2020 · 3 comments
Open

x/tools/gopls: regtest timeouts on openbsd builders #42789

findleyr opened this issue Nov 23, 2020 · 3 comments
Assignees
@findleyr
Labels
Testing Tools gopls
Projects
vscode-go: gopls by default
Milestone
gopls/v1.0.0

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented Nov 23, 2020

Recently, the gopls regtests (golang.org/x/tools/gopls/regtest) have started timing out on openbsd builders with troubling frequency. For example https://storage.googleapis.com/go-build-log/48a1a518/openbsd-amd64-64_32e2acff.log

This didn't seem like a slow uptick in timeout frequency, so might not simply be an artifact of us bumping up against a threshold.

This needs investigation to determine if it is a regression. If it is not, we can move the openbsd regtests to slowbots.

CC @stamblerre @heschik
@gopherbot gopherbot added this to the Unreleased milestone Nov 23, 2020
@findleyr findleyr self-assigned this Nov 23, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 24, 2020

Change https://golang.org/cl/272687 mentions this issue: gopls/internal/regtest: skip regtests for openbsd-amd64-64 on TryBots
gopherbot pushed a commit to golang/tools that referenced this issue Nov 24, 2020
@findleyr
gopls/internal/regtest: skip regtests for openbsd-amd64-64 on TryBots
911501b 
This build is suddenly timing out with high frequency. This requires
investigation, but for now we must get builds passing again.

For golang/go#42789

Change-Id: I51dc5eab227cfb77cd3021438f1b161b21f69caf
Reviewed-on: https://go-review.googlesource.com/c/tools/+/272687
Run-TryBot: Robert Findley <rfindley@google.com>
Trust: Robert Findley <rfindley@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@stamblerre stamblerre added the Testing label Nov 24, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 24, 2020
@stamblerre stamblerre moved this from Needs Triage to Testing in vscode-go: gopls by default Nov 25, 2020
@findleyr
Copy link
Contributor Author

@findleyr findleyr commented Nov 30, 2020

While bisecting this using gomote I found a few minor regressions in gopls, but also found that the test times out at even old gopls commits using go tip, and yet completes in ~300s (half the test timeout of 10m) using go1.15.5.

So this may be a regression in the go command, at least the way gopls uses it.
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 23, 2020

Change https://golang.org/cl/280092 mentions this issue: gopls/internal/regtest: skip a some new builders where regtests time out
gopherbot pushed a commit to golang/tools that referenced this issue Dec 23, 2020
@findleyr
gopls/internal/regtest: skip a some new builders where regtests time out
3e0a2b7 
Updates golang/go#42789
Updates golang/go#43355

Change-Id: Ic344237e492b08c30c4d86db6a6a39a561e2d27b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/280092
Run-TryBot: Robert Findley <rfindley@google.com>
Trust: Robert Findley <rfindley@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
Testing Tools gopls
Projects
vscode-go: gopls by default
  
Testing
Milestone
gopls/v1.0.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@stamblerre @gopherbot @findleyr
You can’t perform that action at this time.