Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: workspace symbols not showing test names in a test variant #42791

Closed
stamblerre opened this issue Nov 23, 2020 · 2 comments
Closed
Assignees
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Nov 23, 2020

To reproduce, search for TestFindWorkspaceRoot in golang.org/x/tools/internal/lsp/cache.

/cc @findleyr

@stamblerre stamblerre added this to the gopls/unplanned milestone Nov 23, 2020
@findleyr findleyr self-assigned this Nov 23, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 24, 2020

Change https://golang.org/cl/272686 mentions this issue: internal/lsp/source: simplify workpsace symbol package collection

@stamblerre stamblerre added this to Non-critical in vscode-go: gopls by default Nov 25, 2020
vscode-go: gopls by default automation moved this from Non-critical to Done Dec 1, 2020
@stamblerre stamblerre reopened this Dec 1, 2020
vscode-go: gopls by default automation moved this from Done to In progress Dec 1, 2020
@stamblerre stamblerre removed this from In progress in vscode-go: gopls by default Dec 4, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 7, 2020

Change https://golang.org/cl/274243 mentions this issue: internal/lsp/source: simplify workspace symbol package collection

marwan-at-work added a commit to marwan-at-work/tools that referenced this issue Dec 23, 2020
While evaluating workspace symbols, we avoid duplicate packages per
package path in an effort to save computing time and eliminate duplicate
results. But for simplicity, we later guard to ensure that we don't ever
walk files twice.

We can just rely on this guard to prevent duplication, and walk all
known packages. This ensures we don't miss symbols, at minimal
additional cost, and simplies the code.

This is a roll-forward of CL 272686, which was accidentally submitted
too early.

Fixes golang/go#42791

Change-Id: I8c39b7afe6c38fedb0e21831d88c28d13d51f102
Reviewed-on: https://go-review.googlesource.com/c/tools/+/274243
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants