Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: insufficient line-height for bullet lists in rendered markdown #42800

Closed
cespare opened this issue Nov 24, 2020 · 1 comment
Closed

x/pkgsite: insufficient line-height for bullet lists in rendered markdown #42800

cespare opened this issue Nov 24, 2020 · 1 comment

Comments

@cespare
Copy link
Contributor

@cespare cespare commented Nov 24, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/gonum.org/v1/plot, for example

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.183 Safari/537.36

Screenshot

bullet1

Note how the text in the bullet list is a little squeezed. The line-height isn't explicitly set, so it takes the default value, which at least in my browser is uncomfortably small. Note how the <code> sections even overlap a little with the adjacent lines.

Here's a screenshot with the ul's line-height set to 24px, which is the line-height of the surrounding paragraphs of text:

bullet2

@gopherbot gopherbot added the pkgsite label Nov 24, 2020
@gopherbot gopherbot added this to the Unreleased milestone Nov 24, 2020
@jba jba modified the milestones: Unreleased, pkgsite/unplanned Nov 24, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 24, 2020

Change https://golang.org/cl/272826 mentions this issue: content/static: fix line-height for bullet lists in rendered markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants