Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: "/" key should place the cursor on the search bar on the homepage and search page #42819

Closed
jadekler opened this issue Nov 25, 2020 · 6 comments

Comments

@jadekler
Copy link
Member

@jadekler jadekler commented Nov 25, 2020

This is a feature request to add similar behavior as youtube, drive, etc.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Nov 30, 2020

This should have already been fixed in #36805. @jadekler - could you confirm if that is the feature you are requesting?

@jadekler
Copy link
Member Author

@jadekler jadekler commented Nov 30, 2020

Yes, that is the feature. It appears to have regressed.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Nov 30, 2020

The feature works for me on Chrome 86 on macOS (Catalina). Which URL are you looking at and what browser are you using?

@jadekler
Copy link
Member Author

@jadekler jadekler commented Nov 30, 2020

Ah, it does indeed work on a specific package. Apologies.

However, it does not work on the homepage (pkg.go.dev). Not sure if this bug should be re-purposed to address that specific page?

edit: I'm using glinux (debian-ish for non-googlers) on chrome.

@julieqiu julieqiu changed the title x/pkgsite: the "/" key places the cursor on the search bar x/pkgsite: "/" key places the cursor on the search bar on the homepage Nov 30, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Nov 30, 2020

Not sure if this bug should be re-purposed to address that specific page?

Yup! Updated the title.

@julieqiu julieqiu changed the title x/pkgsite: "/" key places the cursor on the search bar on the homepage x/pkgsite: "/" key should place the cursor on the search bar on the homepage and search page Dec 1, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Dec 1, 2020

There's actually already an issue filed for this. Closing as a duplicate of #42704.

@julieqiu julieqiu closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants