x/tools/gopls: consider adding opt-in support for symlinks #42833
Labels
Milestone
Comments
Change https://golang.org/cl/273190 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Dec 1, 2020
We currently have partial, untested support for symlinks. Remove all support for now until we come up with a decision. I thought we could re-enable the OpenBSD trybot since we think it was failing because of the latency of evaluating symlinks, but it seems like it's still failing. Updates golang/go#42833 Change-Id: Iece1741def4eaaeffe5fecd10f884c1cce87f449 Reviewed-on: https://go-review.googlesource.com/c/tools/+/273190 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently have partial support for symlinks and no test coverage. We believe that some of the timeouts on the openbsd builder may be caused by the latency of evaluating symlinks.
Some options:
/cc @heschik @findleyr
The text was updated successfully, but these errors were encountered: