x/tools/gopls: consider adding opt-in support for symlinks #42833
We currently have partial support for symlinks and no test coverage. We believe that some of the timeouts on the openbsd builder may be caused by the latency of evaluating symlinks.
/cc @heschik @findleyr
The text was updated successfully, but these errors were encountered:
We currently have partial, untested support for symlinks. Remove all support for now until we come up with a decision. I thought we could re-enable the OpenBSD trybot since we think it was failing because of the latency of evaluating symlinks, but it seems like it's still failing. Updates golang/go#42833 Change-Id: Iece1741def4eaaeffe5fecd10f884c1cce87f449 Reviewed-on: https://go-review.googlesource.com/c/tools/+/273190 Trust: Rebecca Stambler <email@example.com> Run-TryBot: Rebecca Stambler <firstname.lastname@example.org> gopls-CI: kokoro <email@example.com> TryBot-Result: Go Bot <firstname.lastname@example.org> Reviewed-by: Heschi Kreinick <email@example.com> Reviewed-by: Robert Findley <firstname.lastname@example.org>
This would painfully impact productivity if your editor has no support for opening multiple modules in single workspace.
First of all,
Yes, you can make gopls.mod and maintain that by hand. But that's not really a comparable option.
This also can be solved by allowing LSP client to provide workspace information (e.g. vscode has multi-root workspaces where every root not required to be in same subdirectory). But I am not aware if that's a thing right now.